Allow for dependent nullify to happen on soft destroy

[Braden-077]

Why?

This PR adds the cascade effect to dependencies with dependent: :nullify by nullifying the dependency on soft destroy.

Note: this is an opt-in behavior, pulled from a specific use case within RoleModel. It's a draft for the moment just to see if this is worth pulling in.

What Changed

• Add nullify to soft destroy (following what Rails nullify does)

[justwiebe]

Hmm, this would come in handy for a specific case in Gimme Credit https://github.com/RoleModel/gimme-credit/pull/495/files

Is there a reason you aren't checking belongs_to and has_one associations?

@BlaineIrvin perhaps we should use this pattern in Gimme Credit?

[Braden-077]

@justwiebe No, the has_one would be another good one to include!

I'm curious why we'd need to do anything to our belongs_to, could you explain that one?

[justwiebe]

belongs_to might be an even bigger edge case, but for our situation, we've got a chain of reports that "replace" the previous one. We disallow soft destroying a report in the middle of the chain to side step complications, but we do allow soft destroying the latest report. To keep the chain linear, we decided to remove the soft destroyed one from it altogether be removing the belongs_to association

[Braden-077]

It sounds like you're having the child class nullify its own association. There could CERTAINLY be value in that one!

[Braden-077]

That sounds like an after_soft_destroy :nullify_self

[BlaineIrvin]

I'm not sure that belongs_to would fit into this pattern, since it looks like it can't be dependent nullify, only delete, destroy, and destroy_async.

[Braden-077]

Well sure, maybe not out of the box. You could use an arbitrary value on that dependent call. 😉

[Braden-077]

@justwiebe @BlaineIrvin Thinking back on this - I'm going to add the has_one update. I think the specific case of the parent record might be best solved by touching the parent record.