Skip to content

feat(serverless): wire stop, resume and delete into the CLI - #94

Merged
Ryank90 merged 2 commits into
rc/serverlessfrom
feat/runserv-503-v2
Aug 20, 2026
Merged

feat(serverless): wire stop, resume and delete into the CLI#94
Ryank90 merged 2 commits into
rc/serverlessfrom
feat/runserv-503-v2

Conversation

@Ryank90

@Ryank90 Ryank90 commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Implement runware serverless apps stop|resume|delete against stopDeployment, resumeDeployment, and deleteDeployment (202 accepted, no wait/poll).
  • Print the updated deployment (table/json/yaml). Delete prompts unless --yes/--force; missing API key fails before the prompt.
  • Stacked on fix(serverless): log debug path from the HTTP request #93 (fix/log-request-path). feat/runserv-503 still sits on the pre-force-push tip and should not be used.

Test plan

  • go test -race ./internal/api/serverless/ ./internal/cmd/serverless/
  • make lint
  • Manual on a disposable app: stopshow until stopped → resumeshow until active → delete --yes
  • Confirm 409 on stop when not active / resume when not stopped, 404 on unknown id, delete prompt on a TTY

Made with Cursor

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include coderabbit-review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 59d04bd0-26c6-4c16-a7e8-c611776c530d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds full lifecycle management for Serverless apps to the Runware CLI by wiring stop, resume, and delete to the serverless deployments API (fire-and-forget 202 Accepted), including a safety confirmation flow for deletes and updated command docs.

Changes:

  • Replaces stub serverless apps stop|resume|delete commands with real implementations that call StopDeployment, ResumeDeployment, and DeleteDeployment and print the returned deployment.
  • Adds a TTY-aware delete confirmation prompt (skippable via --yes/-y or --force), failing early on missing API key.
  • Extends the serverless API client with lifecycle endpoints plus corresponding tests, and updates generated command docs.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
internal/cmd/serverless/apps.go Wires stop/resume/delete into the apps command group using the shared logger.
internal/cmd/serverless/apps_lifecycle.go Implements stop/resume/delete commands, shared lifecycle runner, and delete confirmation logic.
internal/cmd/serverless/apps_lifecycle_test.go Adds tests for delete confirmation behavior and delete flag parsing.
internal/api/serverless/client.go Adds Stop/Resume/Delete deployment client calls and a shared acceptedDeployment response handler.
internal/api/serverless/client_test.go Adds lifecycle API tests for happy-path, 404, 409 (where applicable), and no-api-key behavior.
docs/runware_serverless_apps_stop.md Updates command synopsis to reflect real stop behavior (202 accepted, async).
docs/runware_serverless_apps_resume.md Updates command synopsis to reflect real resume behavior (202 accepted, async).
docs/runware_serverless_apps_delete.md Updates synopsis/examples/options to include confirmation behavior and skip flags.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread internal/cmd/serverless/apps_lifecycle_test.go Outdated
Base automatically changed from fix/log-request-path to rc/serverless August 19, 2026 09:11
@Ryank90
Ryank90 force-pushed the feat/runserv-503-v2 branch from 2141091 to 852e7f4 Compare August 19, 2026 09:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

@Ryank90
Ryank90 merged commit 0144c4e into rc/serverless Aug 20, 2026
5 checks passed
@Ryank90
Ryank90 deleted the feat/runserv-503-v2 branch August 20, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants