kuznyechik: remove unnecessary mut in f.call() - #584
Merged
newpavlov merged 1 commit intoAug 26, 2026
Conversation
Newer clippy versions flag `unnecessary_mut_passed` when calling `f.call(&mut Backend)` on a trait method that takes `&self` (immutable reference). Remove the excess `mut` to satisfy `-D warnings`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Newer clippy versions flag
unnecessary_mut_passedwhen callingf.call(&mut Backend)on theBlockCipherEncClosure::call/BlockCipherDecClosure::calltrait methods, which take&self(not&mut self).With
-D warningsin CI, this breaks the build on newer toolchains.Remove the excess
mutin bothbig_soft/mod.rsandcompact_soft/mod.rs.Verification
cargo clippy --all --exclude aes --all-features -- -D warningspasses.