Allow passing in timeout/retry settings to Net::HTTP

[tjschuck]

When fetching remote XML files from arbitrary URLs, you might want to configure different values for timeouts/retries to avoid allowing users to DoS you via intentionally slow endpoints. The Net::HTTP defaults are 60 seconds plus 1 retry, which could easily deplete resources if intentionally exploited.

[tjschuck]

Just bumping this — @pitbulk anything I can do to help get this merged and shipped?

[johnnyshields]

@pitbulk this looks reasonable to merge.

[pitbulk]

@johnnyshields I think its ok, but I gonna prefer request_options to be the last paramter of parse_remote and parse_remote_to_array methods, rather than include them before the options parameter.

@tjschuck can you do the change?

[tjschuck]

@pitbulk Pushed!

Thanks @pitbulk and @johnnyshields

[johnnyshields]

Sorry to bikeshed this, I misread @pitbulk's earlier comment. I was thinking we would make these just part of options. But I guess it's fine this way too.

[tjschuck]

@johnnyshields That's fine with me too. I honestly can't remember why I did it this way...

If you want me to push it into options, just let me know and I can do that shortly.

[pitbulk]

@johnnyshields I think it's ok to have both options differentiated. As we are introducing now all related to the request, I'm not against to leave its own place. Wonder if there is a way to inject them in the request rather than initialize each parameter one by one.

 http.open_timeout = request_options[:open_timeout] if request_options[:open_timeout]
 http.read_timeout = request_options[:read_timeout] if request_options[:read_timeout]
 http.max_retries = request_options[:max_retries] if request_options[:max_retries]

[johnnyshields]

oops this is wrong position

[johnnyshields]

Using one options arg avoids human errors like the one I just caught. I strongly prefer it. @pitbulk may we do it?

[pitbulk]

Also this should go on branch V2.0.0 where we force new ruby version

[johnnyshields]

@tjschuck I'll take this one over.

[tjschuck]

@johnnyshields Go nuts! Thanks.

[johnnyshields]

Replaced by #709