v2.0: Deprecate compress_request and compress_response #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyshields
changed the title
johnnyshields
force-pushed
the
deprecate-compress-request
branch
from
90d3b15
to
4a1dfd4
Compare
…e parameters. Set their behavior automatically based on settings.idp_sso_service_binding and settings.idp_slo_service_binding respectively. HTTP-Redirect will always use compression, while HTTP-POST will not.
johnnyshields
force-pushed
the
deprecate-compress-request
branch
from
4a1dfd4
to
19a3e15
Compare
pitbulk
reviewed
Jul 9, 2024
|
Added a minor comment, rest seems ok to be merged. |
johnnyshields
commented
Jul 9, 2024
| # @deprecated Will be removed in v2.1.0 | ||
| def compress_request | ||
| compress_deprecation('compress_request', 'idp_sso_service_binding') | ||
| defined?(@compress_request) ? @compress_request : true |
There was a problem hiding this comment.
One more thing I caught, the previous default for these was "true", so it needs to stay that way. Using defined? here will only apply if the user touched the value; if they set it nil then it will become nil
|
@pitbulk conflicts resolved; ready to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #676
Replaces PR #689
Deprecate
compress_requestandcompress_responseparameters. Set their behavior automatically based on settings.idp_sso_service_binding and settings.idp_slo_service_binding respectively. HTTP-Redirect will always use compression, while HTTP-POST will not.As discussed the
encode_raw_samlmethod has been made backward compatible.This also contains light refactoring of
RubySaml::Loggingto add adeprecatemethod and be a singleton module without changing any of its existing method interfaces.