fix(core) Add Support for Multi-line Messages in Select Component Dropdown #12596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Visit the preview URL for this PR (updated for commit 08c6036): https://fundamental-ngx-gh--pr12596-11430-fix-select-for-ffhp79qa.web.app (expires Fri, 01 Nov 2024 14:08:50 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
droshev
requested changes
Oct 18, 2024
khotcholava
changed the title
…opdown closes [#11430](#11430) ## Description - Refactored the select component to manage text display mode. - Adjusted padding in the select component message to eliminate unnecessary space. - Introduced a new input property, textOverflow, to control how text is displayed in the dropdown list, allowing for either ellipsis or full text.
| @@ -327,6 +345,11 @@ export class SelectComponent<T = any> | |||
| /** @hidden */ | |||
| _selectionModel: SelectionModel<OptionComponent>; | |||
|
|
|||
| /** @hidden */ | |||
| get showEllipsis(): boolean { | |||
There was a problem hiding this comment.
Looks good but why bother with this getter function if you could simply do textOverflow === 'ellipsis' in the template?
mikerodonnell89
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(core): Add Support for Multi-line Messages in Select Component Dropdown
closes #11430
Description
After