Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(platform): fdp table - make responsive pop-in areas navigable #12673

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(platform): fdp table - make responsive pop-in areas navigable #12673

wants to merge 2 commits into from

Conversation

khotcholava
Copy link
Contributor

feat(platform): fdp table - make responsive pop-in areas navigable

closes #11004

Description

  • Ensure row navigation works correctly when interacting with pop-in columns using fdpTableColumnResponsive.
  • Malfunction code: showItemsCount input was duplicated.

@khotcholava
feat(platform): fdp table - make responsive pop-in areas navigable
22ef39b 
closes [#11004](#11004)

## Description
Ensure row navigation works correctly when interacting with pop-in columns using `fdpTableColumnResponsive`.
@khotcholava
feat(platform): fdp table - make responsive pop-in areas navigable
a8a8f2e 
closes [#11004](#11004)

## Description
Malfunction code: `showItemsCount` input was duplicated.
@khotcholava khotcholava self-assigned this Oct 30, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 30, 2024

✅ Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit a8a8f2e
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/672217cc1c41140008d859f2
😎 Deploy Preview https://deploy-preview-12673--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

khotcholava
khotcholava commented Oct 30, 2024
View reviewed changes
libs/platform/table/table.component.html
@@ -18,7 +18,7 @@
}
</div>
@if (showGrowingButton) {
<fdp-table-growing-button [showItemsCount]="showItemsCount" [showItemsCount]="true"></fdp-table-growing-button>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed a duplicate showItemsCount input. One instance was hardcoded to true, while the other took its value from the component input. Now, showItemsCount consistently derives its value from the component input.
@mikerodonnell89 @InnaAtanasova

khotcholava
khotcholava commented Oct 30, 2024
View reviewed changes
libs/platform/table/table.component.scss
@@ -492,6 +492,7 @@ fdk-dynamic-portal {
&__body-table {
&.fd-table--pop-in {
.fd-table__row--secondary {
cursor: pointer;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the secondary row clickable and added a pointer cursor to indicate interactivity.
@mikerodonnell89 @InnaAtanasova

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it also needs the active/hover state as well and should be applied to the entire cell

@github-actions GitHub Actions
Copy link

Visit the preview URL for this PR (updated for commit a8a8f2e):

https://fundamental-ngx-gh--pr12673-11004-make-responsiv-7iephpzj.web.app

(expires Sat, 02 Nov 2024 11:30:36 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

@droshev droshev added this to the Sprint 139 - October 2024 milestone Oct 30, 2024
@droshev droshev added the table label Oct 30, 2024
@droshev droshev requested a review from a team October 30, 2024 11:36
mikerodonnell89
mikerodonnell89 requested changes Nov 4, 2024
View reviewed changes
libs/platform/table/table.component.scss
@@ -492,6 +492,7 @@ fdk-dynamic-portal {
&__body-table {
&.fd-table--pop-in {
.fd-table__row--secondary {
cursor: pointer;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it also needs the active/hover state as well and should be applied to the entire cell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikerodonnell89 mikerodonnell89 mikerodonnell89 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@khotcholava khotcholava

Labels
table
Projects
None yet
Milestone
Sprint 140 - November 2024
Development

Successfully merging this pull request may close these issues.

[enhancement] fdp table - make responsive pop-in areas navigatable
3 participants
@khotcholava @mikerodonnell89 @droshev