fix: Update texts + test samples & the respective test snapshots (#344)

SAP · Oct 2, 2024 · 5639a2f · 5639a2f
1 parent b54f553
commit 5639a2f
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 15 deletions.
diff --git a/src/linter/messages.ts b/src/linter/messages.ts
@@ -153,7 +153,7 @@ export const MESSAGE_INFO = {
 		severity: LintMessageSeverity.Error,
 		ruleId: RULES["no-deprecated-api"],
 
-		message: () => `DeclarativeSupport is deprecated.`,
+		message: () => `DeclarativeSupport is deprecated`,
 		details: () =>
 			`Please consider using {@link sap.ui.core.mvc.XMLView XMLViews} or` +
 			` {@link topic:e6bb33d076dc4f23be50c082c271b9f0 Typed Views} instead. For more information,` +
@@ -173,7 +173,7 @@ export const MESSAGE_INFO = {
 		severity: LintMessageSeverity.Error,
 		ruleId: RULES["no-deprecated-api"],
 
-		message: () => `LessSupport is deprecated.`,
+		message: () => `LessSupport is deprecated`,
 		details: () =>
 			"Please consider using UI5 Tooling https://sap.github.io/ui5-tooling/stable/ to compile LESS to CSS on the fly.",
 	},

diff --git a/test/fixtures/linter/rules/NoDeprecatedApi/BootstrapParameters_Deprecations3.html b/test/fixtures/linter/rules/NoDeprecatedApi/BootstrapParameters_Deprecations3.html
@@ -8,7 +8,7 @@
 		data-sap-ui-theme="sap_horizon"
 		data-sap-ui-libs="sap.m"
 		data-sap-ui-async="true"
-		data-sap-ui-on-init="modules:sap/ui/core/plugin/DeclarativeSupport"
+		data-sap-ui-on-init="module:sap/ui/core/plugin/DeclarativeSupport"
 		>
 	</script>
 </head>

diff --git a/test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.md b/test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.md
@@ -79,15 +79,15 @@ Generated by [AVA](https://avajs.dev).
           {
             column: 24,
             line: 11,
-            message: 'DeclarativeSupport is deprecated.',
+            message: 'DeclarativeSupport is deprecated',
             messageDetails: 'Please consider using XMLViews (https://ui5.sap.com/1.120/#/api/sap.ui.core.mvc.XMLView) or Typed Views (https://ui5.sap.com/#/topic/e6bb33d076dc4f23be50c082c271b9f0) instead. For more information, see the documentation on View types (https://ui5.sap.com/#/topic/91f27e3e6f4d1014b6dd926db0e91070).',
             ruleId: 'no-deprecated-api',
             severity: 2,
           },
           {
             column: 24,
             line: 11,
-            message: 'LessSupport is deprecated.',
+            message: 'LessSupport is deprecated',
             messageDetails: 'Please consider using UI5 Tooling https://sap.github.io/ui5-tooling/stable/ to compile LESS to CSS on the fly.',
             ruleId: 'no-deprecated-api',
             severity: 2,
@@ -112,22 +112,14 @@ Generated by [AVA](https://avajs.dev).
     [
       {
         coverageInfo: [],
-        errorCount: 3,
+        errorCount: 2,
         fatalErrorCount: 0,
         filePath: 'BootstrapParameters_Deprecations3.html',
         messages: [
           {
             column: 24,
             line: 11,
-            message: 'Use of deprecated value \'modules:sap/ui/core/plugin/declarativesupport\' for bootstrap parameter \'data-sap-ui-on-init\'',
-            messageDetails: 'Configuration Options and URL Parameters (https://ui5.sap.com/#/topic/91f2d03b6f4d1014b6dd926db0e91070)',
-            ruleId: 'no-deprecated-api',
-            severity: 2,
-          },
-          {
-            column: 24,
-            line: 11,
-            message: 'DeclarativeSupport is deprecated.',
+            message: 'DeclarativeSupport is deprecated',
             messageDetails: 'Please consider using XMLViews (https://ui5.sap.com/1.120/#/api/sap.ui.core.mvc.XMLView) or Typed Views (https://ui5.sap.com/#/topic/e6bb33d076dc4f23be50c082c271b9f0) instead. For more information, see the documentation on View types (https://ui5.sap.com/#/topic/91f27e3e6f4d1014b6dd926db0e91070).',
             ruleId: 'no-deprecated-api',
             severity: 2,

diff --git a/test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.snap b/test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.snap