fix: Enable Render tests

SAP · Oct 23, 2024 · cd4d398 · cd4d398
1 parent f502529
commit cd4d398
Show file tree

Hide file tree

Showing 20 changed files with 350 additions and 42 deletions.
diff --git a/src/linter/ui5Types/SourceFileLinter.ts b/src/linter/ui5Types/SourceFileLinter.ts
@@ -156,7 +156,8 @@ export default class SourceFileLinter {
 			// Analyze renderer property when it's referenced by a variable or even another module
 			// i.e. { renderer: Renderer }
 			if (ts.isIdentifier(node.initializer)) {
-				const {symbol: {declarations}} = this.#checker.getTypeAtLocation(node);
+				const {symbol} = this.#checker.getTypeAtLocation(node);
+				const {declarations} = symbol ?? {};
 				declarations?.forEach((declaration) => this.analyzeControlRendererInternals(declaration));
 			} else {
 				// Analyze renderer property when it's directly embedded in the renderer object

diff --git a/...fixtures/linter/rules/Render/Control_1.js → .../fixtures/linter/rules/Render/1Control.js b/...fixtures/linter/rules/Render/Control_1.js → .../fixtures/linter/rules/Render/1Control.js
@@ -1,5 +1,5 @@
 sap.ui.define(["sap/ui/core/Control"], function (Control) {
-	var myControl = Control.extend("myControl", {
+	var myControl = Control.extend("mycomp.myControl", {
 		metadata: {},
 		renderer: {
 			apiVersion: 1,

diff --git a/test/fixtures/linter/rules/Render/2Control.js b/test/fixtures/linter/rules/Render/2Control.js
@@ -0,0 +1,8 @@
+sap.ui.define(["sap/ui/core/Control", "./2ControlRenderer"], function (Control, Renderer) {
+	var myControl = Control.extend("mycomp.myControl", {
+		metadata: {},
+		renderer: Renderer,
+	});
+
+	return myControl;
+});
diff --git a/...xtures/linter/rules/Render/_Renderer_2.js → ...s/linter/rules/Render/2ControlRenderer.js b/...xtures/linter/rules/Render/_Renderer_2.js → ...s/linter/rules/Render/2ControlRenderer.js
diff --git a/...fixtures/linter/rules/Render/Control_3.js → .../fixtures/linter/rules/Render/3Control.js b/...fixtures/linter/rules/Render/Control_3.js → .../fixtures/linter/rules/Render/3Control.js
@@ -1,5 +1,5 @@
 sap.ui.define(["sap/ui/core/Control"], function (Control) {
-	var myControl = Control.extend("myControl", {
+	var myControl = Control.extend("mycomp.myControl", {
 		metadata: {},
 		renderer: (oRm, oMyControl) => {
 			oRm.openStart("div", oMyControl);

diff --git a/...fixtures/linter/rules/Render/Control_4.js → .../fixtures/linter/rules/Render/4Control.js b/...fixtures/linter/rules/Render/Control_4.js → .../fixtures/linter/rules/Render/4Control.js
@@ -6,11 +6,7 @@ sap.ui.define(["sap/ui/core/Control"], function (Control) {
 		oRm.close("div");
 	};
 
-	const a = zzzz;
-	const b = a;
-	const c = b;
-
-	var myControl = Control.extend("myControl", {
+	var myControl = Control.extend("mycomp.myControl", {
 		metadata: {},
 		renderer,
 	});

diff --git a/test/fixtures/linter/rules/Render/5Control.js b/test/fixtures/linter/rules/Render/5Control.js
@@ -0,0 +1,8 @@
+sap.ui.define(["sap/ui/core/Control", "./5ControlRenderer"], function (Control, Renderer) {
+	var myControl = Control.extend("mycomp.myControl", {
+		metadata: {},
+		renderer: Renderer,
+	});
+
+	return myControl;
+});
diff --git a/...xtures/linter/rules/Render/_Renderer_5.js → ...s/linter/rules/Render/5ControlRenderer.js b/...xtures/linter/rules/Render/_Renderer_5.js → ...s/linter/rules/Render/5ControlRenderer.js
diff --git a/...fixtures/linter/rules/Render/Control_6.js → .../fixtures/linter/rules/Render/6Control.js b/...fixtures/linter/rules/Render/Control_6.js → .../fixtures/linter/rules/Render/6Control.js
@@ -1,5 +1,5 @@
 sap.ui.define(["sap/ui/core/Control"], function (Control) {
-	var myControl = Control.extend("myControl", {
+	var myControl = Control.extend("mycomp.myControl", {
 		metadata: {},
 		renderer: {
 			apiVersion: 2,

diff --git a/test/fixtures/linter/rules/Render/7Control.js b/test/fixtures/linter/rules/Render/7Control.js
@@ -0,0 +1,8 @@
+sap.ui.define(["sap/ui/core/Control", "./7ControlRenderer"], function (Control, Renderer) {
+	var myControl = Control.extend("mycomp.myControl", {
+		metadata: {},
+		renderer: Renderer,
+	});
+
+	return myControl;
+});
diff --git a/...xtures/linter/rules/Render/_Renderer_7.js → ...s/linter/rules/Render/7ControlRenderer.js b/...xtures/linter/rules/Render/_Renderer_7.js → ...s/linter/rules/Render/7ControlRenderer.js
diff --git a/test/fixtures/linter/rules/Render/8Control.js b/test/fixtures/linter/rules/Render/8Control.js
@@ -0,0 +1,8 @@
+sap.ui.define(["sap/ui/core/Control", "./8ControlRenderer"], function (Control, Renderer) {
+	var myControl = Control.extend("mycomp.myControl", {
+		metadata: {},
+		renderer: Renderer,
+	});
+
+	return myControl;
+});
diff --git a/...xtures/linter/rules/Render/_Renderer_8.js → ...s/linter/rules/Render/8ControlRenderer.js b/...xtures/linter/rules/Render/_Renderer_8.js → ...s/linter/rules/Render/8ControlRenderer.js
diff --git a/test/fixtures/linter/rules/Render/Control_2.js b/test/fixtures/linter/rules/Render/Control_2.js
diff --git a/test/fixtures/linter/rules/Render/Control_5.js b/test/fixtures/linter/rules/Render/Control_5.js
diff --git a/test/fixtures/linter/rules/Render/Control_7.js b/test/fixtures/linter/rules/Render/Control_7.js
diff --git a/test/fixtures/linter/rules/Render/Control_8.js b/test/fixtures/linter/rules/Render/Control_8.js
diff --git a/test/lib/linter/_linterHelper.ts b/test/lib/linter/_linterHelper.ts
@@ -82,7 +82,7 @@ export function createTestsForFixtures(fixturesPath: string) {
 		if (!testFiles.length) {
 			throw new Error(`Failed to find any fixtures in directory ${fixturesPath}`);
 		}
-		if (fixturesPath.includes("AsyncComponentFlags")) {
+		if (fixturesPath.includes("AsyncComponentFlags") || fixturesPath.includes("Render")) {
 			const dirName = path.basename(fixturesPath);
 			testDefinition({
 				testName: dirName,