Skip to content

Commit

Permalink
refactor(messages): Use 'no-deprecated-parameter' rule for ODataModel…
Browse files Browse the repository at this point in the history
… V4 constructor
  • Loading branch information
RandomByte committed Sep 13, 2024
1 parent 434de6c commit e813c69
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion src/linter/messages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ export const MESSAGE_INFO = {

[MESSAGE.DEPRECATED_ODATA_MODEL_V4_SYNCHRONIZATION_MODE]: {
severity: LintMessageSeverity.Error,
ruleId: RULES["ui5-linter-no-deprecated-property"],
ruleId: RULES["ui5-linter-no-deprecated-parameter"],

message: ({modelName}: {modelName?: string}) =>
`Usage of deprecated parameter 'synchronizationMode' ` +
Expand Down
8 changes: 4 additions & 4 deletions test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.md
Original file line number Diff line number Diff line change
Expand Up @@ -499,15 +499,15 @@ Generated by [AVA](https://avajs.dev).
line: 29,
message: 'Usage of deprecated parameter \'synchronizationMode\' of constructor \'sap/ui/model/odata/v4/ODataModel\'',
messageDetails: 'As of version 1.110.0, parameter \'synchronizationMode\' is obsolete and must be omitted. See API reference (https://ui5.sap.com/1.120/#/api/sap/ui/model/odata/v4/ODataModel#constructor)',
ruleId: 'ui5-linter-no-deprecated-property',
ruleId: 'ui5-linter-no-deprecated-parameter',
severity: 2,
},
{
column: 3,
line: 32,
message: 'Usage of deprecated parameter \'synchronizationMode\' of constructor \'sap/ui/model/odata/v4/ODataModel\'',
messageDetails: 'As of version 1.110.0, parameter \'synchronizationMode\' is obsolete and must be omitted. See API reference (https://ui5.sap.com/1.120/#/api/sap/ui/model/odata/v4/ODataModel#constructor)',
ruleId: 'ui5-linter-no-deprecated-property',
ruleId: 'ui5-linter-no-deprecated-parameter',
severity: 2,
},
{
Expand Down Expand Up @@ -1670,15 +1670,15 @@ Generated by [AVA](https://avajs.dev).
line: 92,
message: 'Usage of deprecated parameter \'synchronizationMode\' of constructor \'sap/ui/model/odata/v4/ODataModel\' (model: \'odata-v4\')',
messageDetails: 'As of version 1.110.0, parameter \'synchronizationMode\' is obsolete and must be omitted. See API reference (https://ui5.sap.com/1.120/#/api/sap/ui/model/odata/v4/ODataModel#constructor)',
ruleId: 'ui5-linter-no-deprecated-property',
ruleId: 'ui5-linter-no-deprecated-parameter',
severity: 2,
},
{
column: 21,
line: 98,
message: 'Usage of deprecated parameter \'synchronizationMode\' of constructor \'sap/ui/model/odata/v4/ODataModel\' (model: \'odata-v4-via-dataSource\')',
messageDetails: 'As of version 1.110.0, parameter \'synchronizationMode\' is obsolete and must be omitted. See API reference (https://ui5.sap.com/1.120/#/api/sap/ui/model/odata/v4/ODataModel#constructor)',
ruleId: 'ui5-linter-no-deprecated-property',
ruleId: 'ui5-linter-no-deprecated-parameter',
severity: 2,
},
{
Expand Down
Binary file modified test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.snap
Binary file not shown.
4 changes: 2 additions & 2 deletions test/lib/linter/snapshots/linter.ts.md
Original file line number Diff line number Diff line change
Expand Up @@ -463,15 +463,15 @@ Generated by [AVA](https://avajs.dev).
line: 72,
message: 'Usage of deprecated parameter \'synchronizationMode\' of constructor \'sap/ui/model/odata/v4/ODataModel\' (model: \'odata-v4\')',
messageDetails: 'As of version 1.110.0, parameter \'synchronizationMode\' is obsolete and must be omitted. See API reference (https://ui5.sap.com/1.120/#/api/sap/ui/model/odata/v4/ODataModel#constructor)',
ruleId: 'ui5-linter-no-deprecated-property',
ruleId: 'ui5-linter-no-deprecated-parameter',
severity: 2,
},
{
column: 21,
line: 78,
message: 'Usage of deprecated parameter \'synchronizationMode\' of constructor \'sap/ui/model/odata/v4/ODataModel\' (model: \'odata-v4-via-dataSource\')',
messageDetails: 'As of version 1.110.0, parameter \'synchronizationMode\' is obsolete and must be omitted. See API reference (https://ui5.sap.com/1.120/#/api/sap/ui/model/odata/v4/ODataModel#constructor)',
ruleId: 'ui5-linter-no-deprecated-property',
ruleId: 'ui5-linter-no-deprecated-parameter',
severity: 2,
},
{
Expand Down
Binary file modified test/lib/linter/snapshots/linter.ts.snap
Binary file not shown.

0 comments on commit e813c69

Please sign in to comment.