feat: Detect deprecations in ManagedObject metadata #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3xter666
force-pushed
the
feat-managed-object-metadata
branch
from
459374e
to
d14dc4f
Compare
matz3
reviewed
Oct 11, 2024
matz3
previously requested changes
Oct 15, 2024
matz3
reviewed
Oct 15, 2024
test/fixtures/linter/rules/NoDeprecatedApi/Control_ManagedObject.js
Outdated
Show resolved
Hide resolved
matz3
reviewed
Oct 15, 2024
test/fixtures/linter/rules/NoDeprecatedApi/Control_ManagedObject.js
Outdated
Show resolved
Hide resolved
Custom visitor for ManagedObject metadata. It's just another variant for achieving this functionality
d3xter666
force-pushed
the
feat-managed-object-metadata
branch
from
85fd600
to
7d5dffb
Compare
matz3
approved these changes
Oct 16, 2024
Merged
matz3
added a commit
that referenced
this pull request
Oct 18, 2024
The UI5 class inheritance check needs to perform a different check when the UI5 base classes are actually within the current project like it is the case for the sap.ui.core library. In this case the declaration is based on the actual code, not the UI5 type definitions. This change adds a very minimal sap.ui.core project where this scenario can be reproduced without having to test the whole original library. This is a follow-up of #349
matz3
added a commit
that referenced
this pull request
Oct 18, 2024
The UI5 class inheritance check needs to perform a different check when the UI5 base classes are actually within the current project like it is the case for the sap.ui.core library. In this case the declaration is based on the actual code, not the UI5 type definitions. This change adds a very minimal sap.ui.core project where this scenario can be reproduced without having to test the whole original library. This is a follow-up of #349
matz3
added a commit
that referenced
this pull request
Oct 18, 2024
The UI5 class inheritance check needs to perform a different check when the UI5 base classes are actually within the current project like it is the case for the sap.ui.core library. In this case the declaration is based on the actual code, not the UI5 type definitions. This change adds a very minimal sap.ui.core project where this scenario can be reproduced without having to test the whole original library. This is a follow-up of #349
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: CPOUI5FOUNDATION-858
Depends on: #358