Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: negbinom consistency plots now have the correct boundaries #245

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

pabloitu
Copy link
Collaborator

@pabloitu pabloitu commented Nov 15, 2023

Fixes #236 typo/error in poisson_consistency_test that made negativebinomial critical intervals being reversely assigned, thus creating error with matplotlib.

pyCSEP Pull Request Checklist

Type of change:

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1e2badb) 54.95% compared to head (d887da2) 54.95%.

❗ Current head d887da2 differs from pull request most recent head 3101a2f. Consider uploading reports for the commit 3101a2f to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage   54.95%   54.95%           
=======================================
  Files          23       23           
  Lines        3963     3963           
  Branches      578      578           
=======================================
  Hits         2178     2178           
  Misses       1648     1648           
  Partials      137      137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fabiolsilva fabiolsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed reversed plow and phigh values to correct plot boundaries.

Copy link
Contributor

@fabiolsilva fabiolsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed reversed plow and phigh values to correct plot boundaries.

@fabiolsilva fabiolsilva merged commit d764e5f into SCECcode:main Nov 16, 2023
8 checks passed
@pabloitu pabloitu deleted the fix_nb_plot branch August 16, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with Negative Binomial N-test consistency plot
3 participants