Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pycsep requirements for pip installation & ga using pip #250

Merged
merged 5 commits into from
Mar 7, 2024

Conversation

pabloitu
Copy link
Collaborator

@pabloitu pabloitu commented Mar 7, 2024

pip installation was difficult before because cartopy required the system libraries geos and proj. However, from version 0.22.0, cartopy comes with its own wheels to handle those binaries. I updated the reqs by removing geos and proj, but updated the python required version to 3.9.

The github actions for the pycsep-tests and docs were already tested on my fork. Also, added a Dockerfile to create a pycsep image

pyCSEP Pull Request Checklist

Please check out the contributing guidelines for some tips
on making pull requests to pyCSEP.

Fixes issue #(please fill in or delete if not needed).

Type of change:

Please delete options that are not relevant.

  • Documentation update (this pull request adds no new code)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

Copy link
Contributor

@fabiolsilva fabiolsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated requirements and documentation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified pyCSEP requirements due to updates on cartopy.

@fabiolsilva fabiolsilva merged commit c887782 into SCECcode:main Mar 7, 2024
11 checks passed
@pabloitu pabloitu deleted the pip_actions branch August 16, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants