Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more code checks #211

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add more code checks #211

wants to merge 5 commits into from

Conversation

martinmladenov
Copy link
Collaborator

@martinmladenov martinmladenov commented Jun 11, 2023 •
edited
Loading

We had to make some new code checks to use in exams by adding them in the assignment configuration. It's a good idea to add them to Andy.

mauricioaniche
mauricioaniche requested changes Jun 11, 2023
View reviewed changes
Copy link
Contributor

@mauricioaniche mauricioaniche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should write tests for those :)

@mauricioaniche
Copy link
Contributor

@martinmladenov should we close this one?

@martinmladenov
Copy link
Collaborator Author

I think it's useful to have these code checks too. I'll write some tests for them :)

@mauricioaniche
Copy link
Contributor

I just merged method in a class code check!

@martinmladenov
Copy link
Collaborator Author

Ah, I see. Maybe in that case we can keep just the AnnotatedMethod check?

@mauricioaniche
Copy link
Contributor

Yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauricioaniche mauricioaniche mauricioaniche requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinmladenov @mauricioaniche