NgModel support for inputs #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue at #35 |
MonsieurMan
reviewed
Sep 1, 2019
src/components/input/input.tsx
Outdated
| } | ||
|
|
||
| private onInput(ev: Event) { | ||
| private onInput = (ev: Event) => { |
There was a problem hiding this comment.
Declaring methods as fat arrow functions results in them not using the same memory space as normal ones and is heavier.
Is there any reason it has been changed ?
Also, KeyboardEvent should be used instead.
There was a problem hiding this comment.
Yes, the method must send an event from a property in the input component, so it had to remain in its scope.
There was a problem hiding this comment.
https://stenciljs.com/docs/templating-jsx
The solution is to keep a normal function and provide the scope in the render function instead :
onInput={(evt: KeyboardEvent) => this.onInput(evt)}
// or
onInput={this.onInput.bind(this)}
src/components/input/input.e2e.ts
Outdated
| // Given | ||
| const page = await newE2EPage({ | ||
| html: ` | ||
| <wcs-input /> |
There was a problem hiding this comment.
Custom elements are not intended to be used as self-closing, browser behavior is UB on this.
MonsieurMan
force-pushed
the
feat/input-events
branch
from
08da173
to
929e5a2
Compare
Remove wcs-input component, the input is now to be used by wrapping with a form field
MonsieurMan
force-pushed
the
feat/input-events
branch
from
35db320
to
b3caebb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestsComponents wrap native so tests are not our part.