Skip to content

fix(makefile): exclude web install for dbt 1.6 to fix test #5964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuffbyYuki merged 2 commits into from
Aug 21, 2026
+12 −2
Merged

fix(makefile): exclude web install for dbt 1.6 to fix test #5964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40703d2
fix(makefile): exclude web install for dbt 1.6 to fix test
cmgoffena13 Aug 21, 2026
686b859
fix(pr): test ignores lsp and web for dbt 1.6
cmgoffena13 Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,12 @@ jobs:
echo "DBT version is ${{ matrix.dbt-version }} (>= 1.6.0), keeping semantic_models and metrics sections"
fi

make dbt-fast-test
# dbt 1.6 installs without web/lsp (pydantic conflict); skip collecting those tests
if [[ "${{ matrix.dbt-version }}" == "1.6" ]]; then
pytest -n auto -m "dbt and fast" --reruns 3 --ignore=tests/lsp --ignore=tests/web
else
make dbt-fast-test
fi
- name: Test SQLMesh info in sushi_dbt
working-directory: ./examples/sushi_dbt
run: |
Expand Down
7 changes: 6 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,12 @@ install-dev-dbt-%:
echo "Applying numpy<2 constraint for dbt $$version"; \
$(SED_INPLACE) 's/"numpy"/"numpy<2"/g' pyproject.toml; \
fi; \
$(MAKE) install-dev; \
if [ "$$version" = "1.6.0" ]; then \
echo "Installing without web/lsp for dbt 1.6.0 (fastapi>=0.136 needs pydantic v2; dbt 1.6 needs pydantic v1)"; \
$(PIP) install -e ".[dev,slack,dlt]" ./examples/custom_materializations; \
else \
$(MAKE) install-dev; \
fi; \
if [ "$$version" = "1.6.0" ]; then \
echo "Applying overrides for dbt 1.6.0"; \
$(PIP) install 'pydantic>=2.0.0' 'google-cloud-bigquery==3.30.0' 'databricks-sdk==0.28.0' \
Expand Down
Loading