Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve thread-safety #457

Merged
merged 16 commits into from
Sep 25, 2023
Merged

Conversation

markpmitchell
Copy link
Contributor

  1. Eliminate yices_smt2_mt frontend, incorporating multi-thread test functionality into yices_smt2.
  2. Provide a thread-safe implementation of timeouts.
  3. Avoid allocating very large arrays on the stack. (Noticed because it caused threads, which have smaller stacks, to crash.) Variable-sized allocation on the stack is a bad idea if the allocation size is not bounded.
  4. For testing purposes, give thread stacks the same size as the main stack. (Necessary to work around the fact that libcudd uses recursion where it should use iteration in at least one place.)
  5. Enhance check.sh to allow passing additional options to tests and to allow running individual tests.
  6. Clean up error-handling for POSIX threads API.
  7. Fix incorrect order of destruction in yices_exit.

With these changes, all regression tests pass with --enable-mcsat --enable-thread-safety when running the yices_smt2 frontend with 8 threads.

@coveralls
Copy link

Coverage Status

coverage: 64.976% (+0.003%) from 64.973% when pulling 88e4649 on markpmitchell:mcsat-thread-safety into 618cbb3 on SRI-CSL:master.

@disteph disteph merged commit 6d4c28e into SRI-CSL:master Sep 25, 2023
10 checks passed
@disteph
Copy link
Contributor

disteph commented Sep 25, 2023

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants