windows ci -- checking build and test-api on pull requests #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Why is the final test "make check-api" as opposed to "make check"? Are the regression tests too slow? |
Some tests are failing because of printing mismatch under windows. This needs further investigation and may take come time. In the meantime, I wanted to add the window compilation check in CI. And yes, the windows CI (including running the tests) is too slow. That's why I didn't enable for each commit push -- it is enabled for pull requests. |
|
Makes sense!--Mark MitchellOn Oct 7, 2023, at 9:13 PM, Ahmed ***@***.***> wrote:
Looks good to me. Why is the final test "make check-api" as opposed to "make check"? Are the regression tests too slow?
Some tests are failing because of printing mismatch under windows. This needs further investigation and may take come time. In the meantime, I wanted to add the window compilation check in CI.
And yes, the windows CI (including running the tests) is too slow. That's why I didn't enable for each commit push -- it is enabled for pull requests.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: ***@***.***>
|
ahmed-irfan
added a commit
that referenced
this pull request
Oct 9, 2023
* windows ci -- checking build and test-api on pull requests * m4 cygwin * untabify * autoconf cygwin * Update windows_ci.yml fix typo * Update windows_ci.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.