hack: undef status_interrupted to fix windows build #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There’s no backwards compatibility problem on MINGW if the code never compiled before. Did it?
If it didn’t, you could do this:
1. In the enum definition use YICES_STATUS_INTERRUPTED.
2. Elsewhere in yices.h add:
/* To avoid breaking backwards compatibility until Yices 2.8. */
#ifndef MINGW
#define STATUS_INTERRUPTED YICES_STATUS_INTERRUPTED
#endif
Then, change all the .c files to use YICES_STATUS_INTERRUPTED.
That avoids changing the API for 2.7 update releases on non-Windows platforms. And it avoids undef’ing a Windows API macro.
FWIW,
…--
Mark Mitchell
On Oct 9, 2023, at 6:28 PM, Ahmed ***@***.***> wrote:
this hack is a temporary fix for the windows build.
A proper fix (#466 <#466>) will go the Yices 2.8 release.
You can view, comment on, or merge this pull request online at:
#467
Commit Summary
8638a19 <8638a19> hack: undef status_interrupted to fix windows build
File Changes (1 file <https://github.com/SRI-CSL/yices2/pull/467/files>)
M src/include/yices_types.h <https://github.com/SRI-CSL/yices2/pull/467/files#diff-568871607b523aa15c2c53076965871130ee4c3ebe40ba075a8a0cf9c57b52af> (9)
Patch Links:
https://github.com/SRI-CSL/yices2/pull/467.patch
https://github.com/SRI-CSL/yices2/pull/467.diff
—
Reply to this email directly, view it on GitHub <#467>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKVS3BEVFBOJFNRINHHWODX6SQDLAVCNFSM6AAAAAA5ZR7BBCVHI2DSMVQWIX3LMV43ASLTON2WKOZRHEZTIMJRGA2TANA>.
You are receiving this because you are subscribed to this thread.
|
I like it. Updating the PR accordingly. |
|
I agree with that solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this hack is a temporary fix for the windows build.
A proper fix (#466) will go into the Yices 2.8 release.