Merge pull request #2 from SabaSoftware/GenericType_1039

Generic type fix (sq#1039)
SabaSoftware · Mar 1, 2017 · 4f380f0 · 4f380f0
2 parents cd542b6 + d2930b9
commit 4f380f0
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 0 deletions.
diff --git a/JSIL.Libraries/Sources/JSIL.Core.js b/JSIL.Libraries/Sources/JSIL.Core.js
@@ -331,6 +331,10 @@ JSIL.$GetSpecialType = function (name) {
       for (var i = 0, l = ga.length; i < l; i++) {
         var type = ga[i];
         result += "[" + type.get_AssemblyQualifiedName() + "]";
+        if(i<l-1)
+        {
+            result+=","
+        }
       }
 
       result += "]";

diff --git a/Tests/SimpleTestCases/CreateTypeFromName_Issue1039.cs b/Tests/SimpleTestCases/CreateTypeFromName_Issue1039.cs
@@ -0,0 +1,20 @@
+using System;
+using System.Collections.Generic;
+
+public static class Program
+{
+    public static void Main(string[] args)
+    {
+        var dictionary = new Dictionary<A,B>();
+        var dictionaryType = dictionary.GetType();
+        var type = Type.GetType(dictionaryType.FullName);
+        if (type != null)
+            Activator.CreateInstance(type);
+        Console.WriteLine(
+            "{0},{1}", dictionaryType.Name,dictionaryType.FullName
+            );
+    }
+}
+
+public class A { }
+public class B { }
diff --git a/Tests/SimpleTests.csproj b/Tests/SimpleTests.csproj
@@ -151,6 +151,7 @@
     <None Include="SimpleTestCases\NullableUnary_Issue997.cs" />
     <None Include="SimpleTestCasesForTranslatedBcl\Issue1008_MethodReturnType.cs" />
     <None Include="SimpleTestCases\GetTypeFromAssembly_Issue1035.cs" />
+    <None Include="SimpleTestCases\CreateTypeFromName.cs" />
     <Compile Include="SimpleTests.cs" />
     <None Include="SimpleTestCases\BaseAutoProperties.cs" />
     <None Include="SimpleTestCases\OverloadedVirtualMethods.cs" />