Added ListSelector control. #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgonzalez-stw
force-pushed
the
features/listselector-control
branch
from
c92a612
to
d9e7f0f
Compare
jgonzalez-stw
requested changes
Oct 31, 2024
| @@ -177,18 +217,18 @@ private void SelectedListBox_OnMouseDoubleClick( object sender, MouseButtonEvent | |||
|
|
|||
| private static void OnAvailableItemsSourcePropertyChangedEvent( DependencyObject d, DependencyPropertyChangedEventArgs e ) | |||
| { | |||
| ( (ListSelector) d ).OnAvailableItemsSourcePropertyChangedEvent( (IEnumerable) e.OldValue, (IEnumerable) e.NewValue ); | |||
| ( (ListSelector) d ).OnAvailableItemsSourcePropertyChangedEvent( (IEnumerable) e.OldValue, (IEnumerable?) e.NewValue ); | |||
There was a problem hiding this comment.
Good point in taking in account that e.NewValue may be null, but this should be also be considered for e.OldValue.
In fact, just handling nulls in the called function should be enough, maybe the (IEnumerable?) cast here is unnecessary.
There was a problem hiding this comment.
Unnecessary cast has been removed and handled only in the call, also for OldValue.
…ertyChangedEvent call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved ListSelector control, with options to change Available/Selected header names.