Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add member table to database #203

Merged
merged 4 commits into from
Sep 4, 2023
Merged

Add member table to database #203

merged 4 commits into from
Sep 4, 2023

Conversation

kyudori
Copy link
Contributor

@kyudori kyudori commented Sep 2, 2023

Description

Add member table to database

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

How Has This Been Tested?

$ docker compose up

Test Configuration:

  • Java: v11
  • LPVS Release: v1.1.0

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@kyudori @quswjdgma83
@hwan5180 @Basaeng
Add member table to database
43f8f5b 
Signed-off-by: Hankyuhyun <khh5345@naver.com>
Co-authored-by: ByunJeongHeum <quswjdgma83@naver.com>
Co-authored-by: Hwan <shjune5180@naver.com>
Co-authored-by: jongmin Lee <rjsqktod1@gmail.com>
@kyudori
drop member table if member table exists.
1c310af 
Signed-off-by: Hankyuhyun <khh5345@naver.com>
kyudori and others added 2 commits September 3, 2023 22:39
@kyudori
Add DB options.
aaccba4 
Signed-off-by: Han Kyuhyun <khh5345@naver.com>
Co-authored-by: ByunJeongHeum <quswjdgma83@naver.com>
Co-authored-by: Hwan <shjune5180@naver.com>
Co-authored-by: jongmin Lee <rjsqktod1@gmail.com>
@kyudori @quswjdgma83
@hwan5180 @Basaeng
modify member table.
7e571e1 
Signed-off-by: Han Kyuhyun <khh5345@naver.com>
Co-authored-by: ByunJeongHeum <quswjdgma83@naver.com>
Co-authored-by: Hwan <shjune5180@naver.com>
Co-authored-by: jongmin Lee <rjsqktod1@gmail.com>
tiokim
tiokim approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@tiokim tiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov self-requested a review September 4, 2023 14:00
o-kopysov
o-kopysov approved these changes Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@o-kopysov o-kopysov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov merged commit 706424a into Samsung:main Sep 4, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@o-kopysov o-kopysov o-kopysov approved these changes

@tiokim tiokim tiokim approved these changes

@MoonkiHong MoonkiHong Awaiting requested review from MoonkiHong MoonkiHong is a code owner

@tdrozdovsky tdrozdovsky Awaiting requested review from tdrozdovsky tdrozdovsky is a code owner

@v-kerimov v-kerimov Awaiting requested review from v-kerimov

@m-rudyk m-rudyk Awaiting requested review from m-rudyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kyudori @tiokim @o-kopysov @m-rudyk