-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add API for single pull request scan #370
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #370 +/- ##
============================================
- Coverage 90.94% 90.90% -0.04%
+ Complexity 487 486 -1
============================================
Files 47 47
Lines 1700 1737 +37
Branches 206 209 +3
============================================
+ Hits 1546 1579 +33
+ Misses 97 94 -3
- Partials 57 64 +7 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
JaCoCo Test Coverage Summary
|
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
863dd83
to
6b7b0d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is it possible to add the job for running the single scan along with Samsung/LPVS/{PR number}
to the webhook file for ease of verification?
We already have a plan to implement GitHub action for LPVS: #319 |
I want to see if the function works well through the workflow for every PR. |
Current single scan API is implemented for "server mode" of LPVS operation. To check its functionality, we need to run LPVS server somewhere. |
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
[License Pre-Validation Service] No license issue detected Detected licenses: File: src/main/java/com/lpvs/service/LPVSQueueService.java File: src/test/java/com/lpvs/entity/enums/LPVSPullRequestActionTest.java |
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Here is a result of single scan execution |
Thanks for the hard work. It seems good to merge now! |
* feat: Add API for single pull request scan Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * docs: Add new endpoint description in YAML file Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * test: Cover new endpoint by unit tests Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * test: Update unit tests for LPVSPullRequestAction Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * fix: Update endpoint based on the code review comments Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * feat: Add API for single pull request scan Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * docs: Add new endpoint description in YAML file Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * test: Cover new endpoint by unit tests Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * test: Update unit tests for LPVSPullRequestAction Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * fix: Update endpoint based on the code review comments Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * fix: Fix build after incorrect rebase Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * fix: Update code based on the review comments Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> --------- Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
* feat: Add API for single pull request scan Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * docs: Add new endpoint description in YAML file Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * test: Cover new endpoint by unit tests Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * test: Update unit tests for LPVSPullRequestAction Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * fix: Update endpoint based on the code review comments Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * feat: Add API for single pull request scan Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * docs: Add new endpoint description in YAML file Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * test: Cover new endpoint by unit tests Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * test: Update unit tests for LPVSPullRequestAction Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * fix: Update endpoint based on the code review comments Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * fix: Fix build after incorrect rebase Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * fix: Update code based on the review comments Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> --------- Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
* feat: Add API for single pull request scan Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * docs: Add new endpoint description in YAML file Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * test: Cover new endpoint by unit tests Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * test: Update unit tests for LPVSPullRequestAction Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * fix: Update endpoint based on the code review comments Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * feat: Add API for single pull request scan Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * docs: Add new endpoint description in YAML file Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * test: Cover new endpoint by unit tests Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * test: Update unit tests for LPVSPullRequestAction Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * fix: Update endpoint based on the code review comments Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * fix: Fix build after incorrect rebase Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * fix: Update code based on the review comments Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> --------- Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
* feat: Add API for single pull request scan Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * docs: Add new endpoint description in YAML file Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * test: Cover new endpoint by unit tests Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * test: Update unit tests for LPVSPullRequestAction Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * fix: Update endpoint based on the code review comments Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * feat: Add API for single pull request scan Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * docs: Add new endpoint description in YAML file Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * test: Cover new endpoint by unit tests Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * test: Update unit tests for LPVSPullRequestAction Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * fix: Update endpoint based on the code review comments Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * fix: Fix build after incorrect rebase Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * fix: Update code based on the review comments Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> --------- Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Pull Request
Description
Current PR includes a new REST API for a single pull request scan.
Also, it contains code refactoring and UT updates.
Fixes #354
Type of change
Please delete options that are not relevant.
Testing
http://localhost:7896/scan/github.com/samsung/lpvs/370
Checklist: