Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor and update github action workflows #438

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

t-naumenko
Copy link
Collaborator

Pull Request

Description

  1. Add comment with version to each used actions
  2. Add names for some same steps
  3. Update harder/runner action version in check-docker workflow

Type of change

  • Code cleanup/refactoring
  • CI system update

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Tetiana Naumenko <t.naumenko@samsung.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8d1e5ce) 90.75% compared to head (815178f) 90.75%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #438   +/-   ##
=========================================
  Coverage     90.75%   90.75%           
  Complexity      489      489           
=========================================
  Files            47       47           
  Lines          1731     1731           
  Branches        207      207           
=========================================
  Hits           1571     1571           
  Misses           97       97           
  Partials         63       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@o-kopysov o-kopysov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov added the github_actions Pull requests that update GitHub Actions code label Feb 19, 2024
@o-kopysov o-kopysov added this to the v1.4.2 milestone Feb 19, 2024
@o-kopysov o-kopysov merged commit f40dc2b into Samsung:main Feb 19, 2024
8 checks passed
@t-naumenko t-naumenko deleted the ci-minor-changes branch February 19, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants