Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update pom.xml #441

Merged
merged 1 commit into from
Feb 23, 2024
Merged

build: update pom.xml #441

merged 1 commit into from
Feb 23, 2024

Conversation

o-konoval
Copy link
Collaborator

@o-konoval o-konoval commented Feb 22, 2024

Make standalone jar

Pull Request

fix: update pom.xml

Description

This addition help to create standalone jar- it is very important for using on servers that do not have access to Internet.
Before change needed to add in container dependencies to run jar on remote server.

Type of change

  • New feature (non-breaking change which adds functionality)

Testing

Test Configuration:

  • Java: v17
  • LPVS Release: v1.4.1
  • Tested on server
  • allowed to run standalone jar in container

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Make standalone jar

Signed-off-by: o-konoval <110225527+o-konoval@users.noreply.github.com>
@o-kopysov o-kopysov added the dependencies Pull requests that update a dependency file label Feb 22, 2024
@o-kopysov o-kopysov added this to the v1.4.2 milestone Feb 22, 2024
Copy link
Collaborator

@o-kopysov o-kopysov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov changed the title fix: update pom.xml build: update pom.xml Feb 22, 2024
Copy link
Collaborator

@t-naumenko t-naumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov merged commit 6fa0e02 into main Feb 23, 2024
10 checks passed
@o-kopysov o-kopysov deleted the update-pom branch February 23, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants