Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify single scan feature #463

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

m-rudyk
Copy link
Collaborator

@m-rudyk m-rudyk commented Mar 4, 2024

Pull Request

Description

  1. add loading diff before analyzing files for single scan;
  2. add manual database init before using;

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 90.65%. Comparing base (6cdeca2) to head (79c1481).

Files Patch % Lines
...main/java/com/lpvs/service/LPVSLicenseService.java 86.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #463      +/-   ##
============================================
- Coverage     90.74%   90.65%   -0.09%     
- Complexity      489      491       +2     
============================================
  Files            47       47              
  Lines          1729     1745      +16     
  Branches        208      210       +2     
============================================
+ Hits           1569     1582      +13     
  Misses           97       97              
- Partials         63       66       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@o-kopysov o-kopysov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see any updates compared to the diff I provided.

src/main/resources/application.properties Outdated Show resolved Hide resolved
src/test/java/com/lpvs/service/LPVSDetectServiceTest.java Outdated Show resolved Hide resolved
@o-kopysov o-kopysov added the fix label Mar 5, 2024
@o-kopysov o-kopysov added this to the v1.4.2 milestone Mar 5, 2024
Signed-off-by: Mykola Rudyk <m.rudyk@samsung.com>
Signed-off-by: Mykola Rudyk <m.rudyk@samsung.com>
@m-rudyk m-rudyk requested a review from o-kopysov March 5, 2024 07:55
@m-rudyk m-rudyk marked this pull request as ready for review March 5, 2024 07:55
@@ -14,6 +14,7 @@ license_conflict=db

# Logger configuration
logging.pattern.console=%d{dd-MM-yyyy HH:mm:ss.SSS} %magenta([%thread]) %highlight(%-5level) %logger.%M - %msg%n
spring.profiles.active=singlescan
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is not required here.
Also, please modify the next property in application-singlescan.properties:
spring.datasource.url=jdbc:h2:mem:singlescan;DATABASE_TO_UPPER=false;MODE=MySQL;NON_KEYWORDS=USER;DB_CLOSE_ON_EXIT=FALSE

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: Mykola Rudyk <m.rudyk@samsung.com>
@o-kopysov o-kopysov self-requested a review March 5, 2024 10:19
Copy link
Collaborator

@o-kopysov o-kopysov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@o-konoval o-konoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job for fix the issue. Approved.

@o-kopysov o-kopysov merged commit cfc05c6 into Samsung:main Mar 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants