Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix issues detected by Svace code analyzer #465

Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix: Fix issues detected by Svace code analyzer #465

merged 1 commit into from
Mar 11, 2024

Conversation

o-kopysov
Copy link
Collaborator

@o-kopysov o-kopysov commented Mar 7, 2024

Pull Request

Description

Fix the issues found after the code scanning by the quality analyzer.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 90.91%. Comparing base (5ab9ae9) to head (d302675).

Files Patch % Lines
...vice/scanner/scanoss/LPVSScanossDetectService.java 75.00% 0 Missing and 1 partial ⚠️
src/main/java/com/lpvs/util/LPVSCommentUtil.java 95.83% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #465      +/-   ##
============================================
+ Coverage     90.65%   90.91%   +0.25%     
  Complexity      491      491              
============================================
  Files            47       47              
  Lines          1745     1750       +5     
  Branches        210      210              
============================================
+ Hits           1582     1591       +9     
+ Misses           97       93       -4     
  Partials         66       66              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@o-kopysov
Copy link
Collaborator Author

JaCoCo Test Coverage Summary

  • Coverage: 92.625%
  • Branches: 80.565%

Copy link
Collaborator

@t-naumenko t-naumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov merged commit 33a6e36 into main Mar 11, 2024
10 checks passed
@o-kopysov o-kopysov deleted the svace branch March 11, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants