Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Change visibility of constructor for testability #467

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

o-kopysov
Copy link
Collaborator

Pull Request

Description

PR contains a change that is required for the correct operation of dependent modules.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

@o-kopysov o-kopysov added this to the v1.4.3 milestone Mar 19, 2024
@o-kopysov o-kopysov self-assigned this Mar 19, 2024
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.91%. Comparing base (4e0b8cf) to head (8487616).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #467   +/-   ##
=========================================
  Coverage     90.91%   90.91%           
  Complexity      491      491           
=========================================
  Files            47       47           
  Lines          1750     1750           
  Branches        210      210           
=========================================
  Hits           1591     1591           
  Misses           93       93           
  Partials         66       66           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@o-konoval o-konoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov merged commit 8ac4581 into main Mar 19, 2024
10 checks passed
@o-kopysov o-kopysov deleted the refact-1 branch March 19, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants