Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Load scan services dynamically based on configuration properties #470

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

o-kopysov
Copy link
Collaborator

@o-kopysov o-kopysov commented Mar 26, 2024

Pull Request

Description

Load scan services dynamically based on configuration properties.
The proposed approach provides flexibility for loading different scanners without changes in the source code.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Testing

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Test Configuration:

  • Java: v17
  • LPVS Release: v1.4.2

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@o-kopysov o-kopysov added this to the v1.4.3 milestone Mar 26, 2024
@o-kopysov o-kopysov self-assigned this Mar 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.98%. Comparing base (839cab1) to head (57da4d6).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #470      +/-   ##
============================================
+ Coverage     90.91%   90.98%   +0.06%     
- Complexity      491      495       +4     
============================================
  Files            47       48       +1     
  Lines          1750     1763      +13     
  Branches        210      211       +1     
============================================
+ Hits           1591     1604      +13     
  Misses           93       93              
  Partials         66       66              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@o-kopysov o-kopysov changed the title [WIP] feat: Load service dynamically based on configuration property feat: Load scan services dynamically based on configuration properties Mar 27, 2024
@o-kopysov o-kopysov marked this pull request as ready for review March 27, 2024 06:30
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Copy link
Collaborator

@t-naumenko t-naumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement.
LGTM

@o-kopysov o-kopysov merged commit a22271b into main Mar 27, 2024
10 checks passed
@o-kopysov o-kopysov deleted the service-loading branch March 27, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants