-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Refactor LoginCheck and existing unit test for License Service #523
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #523 +/- ##
============================================
+ Coverage 91.47% 92.28% +0.80%
- Complexity 520 524 +4
============================================
Files 48 48
Lines 1737 1736 -1
Branches 210 210
============================================
+ Hits 1589 1602 +13
+ Misses 82 69 -13
+ Partials 66 65 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mykola Rudyk <m.rudyk@samsung.com>
Signed-off-by: Mykola Rudyk <m.rudyk@samsung.com>
d24560f
to
41f3ef0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Mykola Rudyk <m.rudyk@samsung.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request
Description
Type of change
Please delete options that are not relevant.
Testing
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Test Configuration:
Checklist: