Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor LoginCheck and existing unit test for License Service #523

Merged
merged 3 commits into from
May 31, 2024

Conversation

m-rudyk
Copy link
Collaborator

@m-rudyk m-rudyk commented May 28, 2024

Pull Request

Description

  • Modify LoginCheck to remove unnecessary function;
  • refactor unit tests for LicenseService, improving coverage;

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Testing

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Test Configuration:

  • Java: v17
  • LPVS Release: v1.x.x

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.28%. Comparing base (8a6f674) to head (dd83da1).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #523      +/-   ##
============================================
+ Coverage     91.47%   92.28%   +0.80%     
- Complexity      520      524       +4     
============================================
  Files            48       48              
  Lines          1737     1736       -1     
  Branches        210      210              
============================================
+ Hits           1589     1602      +13     
+ Misses           82       69      -13     
+ Partials         66       65       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mykola Rudyk <m.rudyk@samsung.com>
Signed-off-by: Mykola Rudyk <m.rudyk@samsung.com>
@m-rudyk m-rudyk force-pushed the m.rudyk/refactor_unit_tests branch from d24560f to 41f3ef0 Compare May 28, 2024 11:54
@m-rudyk m-rudyk changed the title M.rudyk/refactor unit tests refactor existing unit test for License Service, refactor LoginCheck May 28, 2024
@m-rudyk m-rudyk marked this pull request as ready for review May 28, 2024 11:58
Copy link
Collaborator

@o-kopysov o-kopysov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Mykola Rudyk <m.rudyk@samsung.com>
@o-kopysov o-kopysov changed the title refactor existing unit test for License Service, refactor LoginCheck refactor: Refactor LoginCheck and existing unit test for License Service May 29, 2024
@o-kopysov o-kopysov added the enhancement New feature or request label May 29, 2024
@o-kopysov o-kopysov added this to the v1.5.2 milestone May 29, 2024
Copy link
Collaborator

@t-naumenko t-naumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov merged commit 03b112d into Samsung:main May 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants