Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: User friendly command line report for single scan #577

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

o-kopysov
Copy link
Collaborator

Pull Request

Description

Current PR contains an updated, user-friendly version of the command line report for single scans (PR or local files).

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Testing

Tested locally for PR and local file scan.

image

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
@o-kopysov o-kopysov added the enhancement New feature or request label Aug 23, 2024
@o-kopysov o-kopysov added this to the v2.0.0 milestone Aug 23, 2024
@o-kopysov o-kopysov self-assigned this Aug 23, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 94.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.57%. Comparing base (1b69e16) to head (c427c0c).

Files Patch % Lines
src/main/java/com/lpvs/entity/LPVSFile.java 87.87% 1 Missing and 3 partials ⚠️
...java/com/lpvs/entity/report/LPVSReportBuilder.java 98.18% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #577      +/-   ##
============================================
+ Coverage     93.28%   93.57%   +0.28%     
- Complexity      579      583       +4     
============================================
  Files            49       49              
  Lines          1982     2009      +27     
  Branches        232      234       +2     
============================================
+ Hits           1849     1880      +31     
+ Misses           63       59       -4     
  Partials         70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@t-naumenko t-naumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@m-rudyk m-rudyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objection, approved.

@o-kopysov o-kopysov merged commit 62d4c96 into main Aug 27, 2024
10 checks passed
@o-kopysov o-kopysov deleted the command-line-report branch August 27, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants