Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Renovation of LPVS logo adjustable to the GitHub theme #579

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

o-kopysov
Copy link
Collaborator

Pull Request

Description

Renovation of LPVS logo adjustable to the GitHub theme.
dark and light

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
@o-kopysov o-kopysov added the documentation Improvements or additions to documentation label Aug 29, 2024
@o-kopysov o-kopysov added this to the v2.0.0 milestone Aug 29, 2024
@o-kopysov o-kopysov self-assigned this Aug 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.57%. Comparing base (62d4c96) to head (e3aa896).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #579   +/-   ##
=========================================
  Coverage     93.57%   93.57%           
  Complexity      583      583           
=========================================
  Files            49       49           
  Lines          2009     2009           
  Branches        234      234           
=========================================
  Hits           1880     1880           
  Misses           59       59           
  Partials         70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@o-konoval o-konoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, it looks nice. Approved.

Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
@o-kopysov o-kopysov merged commit ccc06c1 into main Aug 30, 2024
10 checks passed
@o-kopysov o-kopysov deleted the new-logo branch August 30, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants