Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Warning messages removal during the build process #580

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Conversation

o-kopysov
Copy link
Collaborator

Pull Request

Description

Removed all warnings during the build process.
Currently have 0 build warnings.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Testing

Local command line build.

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.67%. Comparing base (006047b) to head (d72de56).

Files with missing lines Patch % Lines
src/main/java/com/lpvs/config/SecurityConfig.java 94.11% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #580      +/-   ##
============================================
- Coverage     93.74%   93.67%   -0.07%     
- Complexity      602      608       +6     
============================================
  Files            49       49              
  Lines          2110     2104       -6     
  Branches        244      244              
============================================
- Hits           1978     1971       -7     
- Misses           60       61       +1     
  Partials         72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@t-naumenko t-naumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov merged commit 8786e50 into main Sep 2, 2024
10 checks passed
@o-kopysov o-kopysov deleted the fix-warn branch September 2, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants