Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve MCD (Module Circular Dependency) metric of the code #615

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

o-kopysov
Copy link
Collaborator

Pull Request

Description

Currently, the source code has several MCD (Module Circular Dependency) that can be fixed to improve the overall LPVS architecture.
Current PR contains the refactoring the code to separate LPVSConflict to the independent class.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Testing

Tested using unit tests.

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
@o-kopysov o-kopysov added the enhancement New feature or request label Sep 18, 2024
@o-kopysov o-kopysov self-assigned this Sep 18, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@149c5a0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/main/java/com/lpvs/entity/LPVSConflict.java 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #615   +/-   ##
=======================================
  Coverage        ?   93.88%           
  Complexity      ?      622           
=======================================
  Files           ?       52           
  Lines           ?     2126           
  Branches        ?      247           
=======================================
  Hits            ?     1996           
  Misses          ?       57           
  Partials        ?       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@t-naumenko t-naumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov merged commit b63cb7a into main Sep 18, 2024
10 checks passed
@o-kopysov o-kopysov deleted the circular-dependency branch September 18, 2024 16:06
@o-kopysov o-kopysov added this to the v2.0.1 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants