feat: Display link to the hub in pull request message when available #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
o-kopysov
requested review from
tiokim,
MoonkiHong and
tdrozdovsky
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #616 +/- ##
============================================
+ Coverage 93.88% 93.94% +0.05%
- Complexity 622 624 +2
============================================
Files 52 52
Lines 2126 2130 +4
Branches 247 248 +1
============================================
+ Hits 1996 2001 +5
+ Misses 57 56 -1
Partials 73 73 ☔ View full report in Codecov by Sentry. |
m-rudyk
previously approved these changes
Sep 19, 2024
Comment on lines
326
to
330
| + (!StringUtils.isBlank(webhookConfig.getHubLink()) | ||
| ? ("\n\n###### <p align='right'>Check the validation details on the [website](" | ||
| + webhookConfig.getHubLink() | ||
| + ")</p>") | ||
| : "")); |
There was a problem hiding this comment.
Too much embeddedness, hard to read; this needs to be stored in a separate value.
Same below
tdrozdovsky
previously approved these changes
Sep 19, 2024
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
tdrozdovsky
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Added the link to the hub link (when available) at the end of the pull request message.
Type of change
Please delete options that are not relevant.
Testing
Tested locally using unit tests.
Checklist: