Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Take SPDX ID from GitHub API when searching for the license #634

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

o-kopysov
Copy link
Collaborator

Pull Request

Description

The current pull request improves the way to take the license of the repository from GitHub (using SPDX ID, not a license key as previously). This change is related to the upgrade of the GitHub library #631 .

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Testing

Checked locally.

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
@o-kopysov o-kopysov added enhancement New feature or request fix labels Oct 4, 2024
@o-kopysov o-kopysov added this to the v2.0.1 milestone Oct 4, 2024
@o-kopysov o-kopysov self-assigned this Oct 4, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.81%. Comparing base (31f6f4d) to head (4a714d1).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #634   +/-   ##
=========================================
  Coverage     93.81%   93.81%           
  Complexity      628      628           
=========================================
  Files            52       52           
  Lines          2150     2150           
  Branches        251      251           
=========================================
  Hits           2017     2017           
  Misses           58       58           
  Partials         75       75           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@t-naumenko t-naumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov merged commit f8b7b1a into main Oct 7, 2024
10 checks passed
@o-kopysov o-kopysov deleted the use-spdxid branch October 7, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants