Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unknown values must raise error for boolean fields instead of be… #51

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

Jumas
Copy link
Contributor

@Jumas Jumas commented Oct 9, 2024

…ing treated as 'false'

Refs: #43

Proposed changes

Raise error when user provides unknown value for boolean fields instead of treating it as 'false' value.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation

@Jumas Jumas requested review from a team as code owners October 9, 2024 16:14
@Jumas Jumas linked an issue Oct 9, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented Oct 9, 2024

@Jumas Jumas enabled auto-merge (squash) October 9, 2024 16:22
@Jumas Jumas merged commit 7415219 into main Oct 11, 2024
10 checks passed
@Jumas Jumas deleted the 43-treat-unknown-values-as-illegal branch October 11, 2024 07:34
@grigoriev grigoriev added this to the v2.8.1 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom value mapping for Boolean attributes
2 participants