Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: sonarcloud quality gate fixes #60

Merged
merged 1 commit into from
Oct 29, 2024
Merged

chore: sonarcloud quality gate fixes #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/ch/sbb/polarion/extension/excel_importer/service/ImportService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ private void fillWorkItemFields(IWorkItem workItem, Map<String, Object> mappingR
boolean ensureValidValue(String fieldId, Object value, Set<FieldMetadata> fieldMetadataSet) {
FieldMetadata fieldMetadata = getFieldMetadataForField(fieldMetadataSet, fieldId);
if (FieldType.BOOLEAN.getType().equals(fieldMetadata.getType()) &&
(!(value instanceof String) || !("true".equalsIgnoreCase((String) value) || "false".equalsIgnoreCase((String) value)))) {
(!(value instanceof String stringValue) || !("true".equalsIgnoreCase(stringValue) || "false".equalsIgnoreCase(stringValue)))) {
throw new IllegalArgumentException(String.format("'%s' isn't a valid boolean value", value == null ? "" : value));
}
return true;
Expand Down
3 changes: 2 additions & 1 deletion ...java/ch/sbb/polarion/extension/excel_importer/settings/ExcelSheetMappingSettingsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,9 @@ void testSettingDoesNotExist() {
ExcelSheetMappingSettingsModel model = excelSheetMappingSettings.defaultValues();
model.setBundleTimestamp("default");

SettingId settingId = SettingId.fromName("Any setting name");
assertThrows(ObjectNotFoundException.class, () -> {
ExcelSheetMappingSettingsModel loadedModel = excelSheetMappingSettings.load(projectName, SettingId.fromName("Any setting name"));
excelSheetMappingSettings.load(projectName, settingId);
});
}
}
Expand Down