Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for SVG is changed #36

Conversation

grigoriev
Copy link
Contributor

binary content can not be SVG

Refs: #35

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation

binary content can not be SVG

Refs: #35
@grigoriev grigoriev requested review from a team as code owners July 22, 2024 15:31
@grigoriev grigoriev linked an issue Jul 22, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented Jul 22, 2024

@Jumas Jumas merged commit 4951a52 into main Jul 22, 2024
8 checks passed
@Jumas Jumas deleted the 35-converting-html-to-pdf-failed-if-no-data-type-provided-in-img-tag branch July 22, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

converting HTML to PDF failed if no data type provided in img tag
2 participants