Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: chromium gpu usage disabled, proper error result handling when t… #54

Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix: chromium gpu usage disabled, proper error result handling when t… #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions app/SvgUtils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,11 @@ def replace_svg_with_png(svg_content):
else:
logging.error('Cannot find svg height in ' + svg_content)
return svg_content

# Log large svg content size
svg_content_length = len(svg_content)
if svg_content_length > 100_000:
logging.warning(f"SVG content length: {svg_content_length}")

# Will be used as a name for tmp files
uuid = str(uuid4())
Expand All @@ -90,24 +95,29 @@ def replace_svg_with_png(svg_content):
f'{chrome_executable}',
'--headless',
'--no-sandbox',
'--disable-gpu',
'--disable-software-rasterizer',
'--disable-dev-shm-usage',
'--default-background-color=00000000',
'--hide-scrollbars',
f'--screenshot={png_filepath}',
f'--window-size={width},{height}',
f'{svg_filepath}',
])

# Remove tmp svg file
os.remove(svg_filepath)

if result.returncode != 0:
logging.error(f'Error converting to png, returncode = {result.returncode}')
return svg_content

# Get resulting screenshot content
with open(png_filepath, 'rb') as img_file:
img_data = img_file.read()
png_base64 = base64.b64encode(img_data).decode('utf-8')

# Remove tmp files
os.remove(svg_filepath)
# Remove tmp png file
os.remove(png_filepath)

if result.returncode != 0:
logging.error('Error converting to png')
return svg_content
else:
return png_base64
return png_base64
Loading