Banded QR for non square matrices

SciML · Oct 25, 2023 · 9fbc583 · 9fbc583
1 parent 4ee3e1e
commit 9fbc583
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/ext/LinearSolveBandedMatricesExt.jl b/ext/LinearSolveBandedMatricesExt.jl
@@ -5,8 +5,14 @@ import LinearSolve: defaultalg,
     do_factorization, init_cacheval, DefaultLinearSolver, DefaultAlgorithmChoice
 
 # Defaults for BandedMatrices
-function defaultalg(A::BandedMatrix, b, ::OperatorAssumptions)
-    return DefaultLinearSolver(DefaultAlgorithmChoice.DirectLdiv!)
+function defaultalg(A::BandedMatrix, b, oa::OperatorAssumptions)
+    if oa.issq
+        return DefaultLinearSolver(DefaultAlgorithmChoice.DirectLdiv!)
+    elseif LinearSolve.is_underdetermined(A)
+        error("No solver for underdetermined `A::BandedMatrix` is currently implemented!")
+    else
+        return DefaultLinearSolver(DefaultAlgorithmChoice.QRFactorization)
+    end
 end
 
 function defaultalg(A::Symmetric{<:Number, <:BandedMatrix}, b, ::OperatorAssumptions)