Fix UMFPACK to use check=false
#474
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #474 +/- ##
=======================================
Coverage 65.98% 65.98%
=======================================
Files 27 27
Lines 2143 2146 +3
=======================================
+ Hits 1414 1416 +2
- Misses 729 730 +1 ☔ View full report in Codecov by Sentry. |
test/default_algs.jl
Outdated
| prob = LinearProblem(A, ones(100)) | ||
| solve(prob) |
There was a problem hiding this comment.
This only shows one solver. Can you make KLU and UMFPACK explicit?
There was a problem hiding this comment.
updated. KLU is still broken (as far as I can see it still doesn't support disabling the checks).
There was a problem hiding this comment.
@rayegun didn't you handle KLU.jl?
There was a problem hiding this comment.
https://github.com/search?q=repo%3AJuliaSparse%2FKLU.jl%20check&type=code
You said you added check=false to klu but I don't see it in the repo. We can merge for now with this test failing but can you follow up with a test passing verison?
This prevents singular exceptions.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.