Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translating the grammar parser #136

Merged
merged 10 commits into from
Aug 30, 2023
Merged

Translating the grammar parser #136

merged 10 commits into from
Aug 30, 2023

Commits on Aug 29, 2023

  1. [WIP] Translating the GrammarParser

    @Mihaiii
    Mihaiii committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    7f31276 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Address PR change requests

    @Mihaiii
    Mihaiii committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    8b4ec6d View commit details
    Browse the repository at this point in the history

  2. Use ReadOnlySpan everywhere instead of ReadOnlyMemeory and instead of… 

    … returning tuple, reference the ReadOnlySpan.
    @Mihaiii
    Mihaiii committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    3c919b5 View commit details
    Browse the repository at this point in the history

  3. Finish grammar_parser translation from C++ to C#

    @Mihaiii
    Mihaiii committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    0f373fc View commit details
    Browse the repository at this point in the history

  4. Add initial tests + fix bugs. Still WIP since the test is failing.

    @Mihaiii
    Mihaiii committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    0bd4952 View commit details
    Browse the repository at this point in the history

  5. Bug fixes after running tests. 

    SymbolIds is now SortedDictionary (although I'm not sure it really needs to be) because the test was failing due to expected value being in another order. The C++ data structure if SymbolIds is std::map<std::string, uint32_t> so the items are ordered by key.
    @Mihaiii
    Mihaiii committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    2ae1891 View commit details
    Browse the repository at this point in the history

  6. Add original test

    @Mihaiii
    Mihaiii committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    920efac View commit details
    Browse the repository at this point in the history

  7. Add grammar example

    @Mihaiii
    Mihaiii committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    71f02e0 View commit details
    Browse the repository at this point in the history

  8. Address code review comments (create custom exception, move printing … 

    …to the ParseState class, rethrow error).
    @Mihaiii
    Mihaiii committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    60790c5 View commit details
    Browse the repository at this point in the history

  9. Address PR review comment

    @Mihaiii
    Mihaiii committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    24d3e1b View commit details
    Browse the repository at this point in the history