🔧 Refactor Semantic Kernel chat completion implementation #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored the chat completion implementation in `LLamaSharpChatCompletion.cs` to use `StatelessExecutor` instead of `InteractiveExecutor`. - Updated the chat history prompt in `LLamaSharpChatCompletion.cs` to include a conversation between the assistant and the user. - Modified the `HistoryTransform` class in `HistoryTransform.cs` to append the assistant role to the chat history prompt. - Updated the constructor of `LLamaSharpChatCompletion` to accept optional parameters for `historyTransform` and `outputTransform`. - Modified the `GetChatCompletionsAsync` and `GetChatCompletions` methods in `LLamaSharpChatCompletion.cs` to use the new `StatelessExecutor` and `outputTransform`. - Updated the `ExtensionMethods.cs` file to include the assistant and system roles in the list of anti-prompts.
|
Just for curiosity, will replacing InteractiveExecutor with StatelessExecutor improve the performance of SK chat? |
|
This will not bring any performance changes. It is just that using StatelessExecutor is more in line with the expectations of the current SK Chat interface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
LLamaSharpChatCompletion.csto useStatelessExecutorinstead ofInteractiveExecutor.Changes
LLamaSharpChatCompletion.csto include a conversation between the assistant and the user.HistoryTransformclass inHistoryTransform.csto append the assistant role to the chat history prompt.LLamaSharpChatCompletionto accept optional parameters forhistoryTransformandoutputTransform.GetChatCompletionsAsyncandGetChatCompletionsmethods inLLamaSharpChatCompletion.csto use the newStatelessExecutorandoutputTransform.ExtensionMethods.csfile to include the assistant and system roles in the list of anti-prompts.Discussion
The current implementation refers to the handling method of History in LLamaSharp ChatSession, but the actual execution effect still needs to be combined with models and prompts.