-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuilt ChatSession class #344
Conversation
philippjbauer
commented
Dec 5, 2023
- Saves with serialized ChatHistory of session
- Only allows use of ChatHistory.Message (instead of raw text) for easy post-processing with IHistoryTransform implementation
- Provides History Management methods
- Allows user to regenerate last assistant message
- Saves with serialized ChatHistory of session - Only allows use of ChatHistory.Message (instead of raw text) for easy post-processing with IHistoryTransform implementation - Provides History Management methods - Allows user to regenerate last assistant message
Thanks for re-submitting this based on master! Overall looks good, just that conflict to resolve and one comment/question. |
I've resolved that for you, please check that I did it right! |
LGTM 👍 |
The tests seems to be failing due to a type checking error, looks like something isn't right with that merge? |
This format of prompt looks good. Is it a commonly used format in LLM now? |
Hmm, I didn't run into these issues before. I thought I had updated everything that depended on the |
What exactly are you referring to? I haven't touched the default |
I mean the following format in the example prompt:
|
This is simply a json representation of the chat history. This will be ultimately transformed by the As such the user (developer) is able to introduce multiple implementations of the This also allows us to package specific |
I synced my master with the latest to get the files that caused issues and updated them to use the new ChatSession integration. The sample for the Chinese character encoding works, but I have a hard time evaluating whether its output is actually correct (I sadly don't know Mandarin). This was a best guess effort on my part. @AsakusaRinne I saw that you committed the code, are you able to verify this? |
@philippjbauer I've added some changes and the Chinese example is generating correct answer now. It's absolutely a good work! |
Thank you! |
Thanks for fixing the merge conflict and the Chinese example. This all looks good to me, ready for merging? |
Good on my part |
Thanks for all your hard work on this PR! |