Logging interceptor #649
Merged
Logging interceptor #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allback - Delaying binding of this into llama.cpp until after `NativeLibraryConfig` has loaded
|
Will this work also suppress native logs from llava? |
|
Unsure. It's just using the llama.cpp logging callback ( |
dlyz
reviewed
Apr 4, 2024
dlyz
reviewed
Apr 4, 2024
dlyz
reviewed
Apr 4, 2024
…_empty_call`, this is specifically selected to be a method that does nothing and is just there for triggering DLL loading.
… always call whatever log callbacks you have registered. - Removed alternative path for `ILogger` in NativeLibraryConfig, instead it redirects to wrapping it in a delegate.
dlyz
reviewed
Apr 4, 2024
dlyz
reviewed
Apr 5, 2024
dlyz
reviewed
Apr 5, 2024
- Using `ThreadLocal<StringBuilder>` to ensure messages from separate threads don't get mixed together.
|
Thanks @martindevans for your work! I have no further notes. |
|
Thanks very much for your detailed review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewritten logging callbacks so it can be configured without touching native methods. This allows it to be used before llama.cpp dll is loaded.
Resolves #645