Interruptible Async Model Loading With Progress Monitoring #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Async loading supports cancellation through a `CancellationToken`. If loading is cancelled an `OperationCanceledException` is thrown. If it fails for another reason a `LoadWeightsFailedException` is thrown. - Updated examples to use `LoadFromFileAsync`
AsakusaRinne
approved these changes
Apr 27, 2024
|
I added an It's not _quite) reporting the raw values. If there are LoRAs to apply it reports model loading in the |
martindevans
changed the title
AsakusaRinne
approved these changes
Apr 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLamaWeights.LoadFromFileAsync.LoadFromFileAsyncCancellationToken:OperationCanceledExceptionis thrown.LoadWeightsFailedExceptionis thrown.This does not expose the progress callback on the
ModelParamsobject. However the code as written does support custom callbacks being set so that can be easily exposed in the future.Resolve #699