Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added some basic trig functions #181

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

kellender
Copy link

For issue #180
sin, cos, tan, csc, sec, cot

@aaaaalbert
Copy link
Contributor

  • Needs unit tests for checking proper functionality.
  • Needs unit tests for checking proper exception handling.
  • Should take parameters in radians, and not convert internally.
  • When in doubt (e.g. on parameters in radians or exception handling), check with Python's math module.
  • Should provide functions to convert degrees from/into radians, and probably something to wrap the argument back into +-pi as well.
  • How commonly used are the 1/sin, 1/cos, 1/tan things? First time I see them defined with own names (but this might be an intercontinental issue.)
  • Pull out the number of decimals places into a CONSTANT, or leave out altogether.
  • Should probably wrap the parameter into +-pi before proceeding.

@aaaaalbert
Copy link
Contributor

Re cosecans et al.: Python's math doesn't seem to have them.

Feature requests:

  • Arcus functions
  • Hyperbolic functions
  • Area functions

kellender and others added 7 commits March 29, 2016 10:20
Arcus functions
Hyperbolic functions
Area functions
sqrt
absolute value
Other fixes include sqrt, and UT spelling errors, and file naming errors
@JustinCappos
Copy link
Contributor

This was needed for the SAS hack-a-thon. Let's fix and merge...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants