Updated Shap saving. #881
Merged
Updated Shap saving. #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ids saving internal explainer.
RobertSamoilescu
force-pushed
the
fix/shap-saving
branch
from
4a95d59
to
a21778b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #881 +/- ##
=======================================
Coverage 85.30% 85.31%
=======================================
Files 74 74
Lines 8774 8779 +5
=======================================
+ Hits 7485 7490 +5
Misses 1289 1289
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jklaise
reviewed
Mar 1, 2023
alibi/saving.py
Outdated
|
|
||
| def _save_KernelShap(explainer: 'KernelShap', path: Union[str, os.PathLike]) -> None: | ||
| _save_Shap(explainer, path) | ||
|
|
||
|
|
||
| def _save_TreelShap(explainer: 'TreeShap', path: Union[str, os.PathLike]) -> None: |
There was a problem hiding this comment.
Just noticed that the function name had a typo, probably good to fix now.
jklaise
reviewed
Mar 1, 2023
| # set the internal explainer object to avoid saving it. The internal explainer | ||
| # object is recreated when in the `reset_predictor` function call. | ||
| _explainer = explainer._explainer | ||
| explainer._explainer = None |
There was a problem hiding this comment.
Just noting that this will need to be considered too when fixing #830
jklaise
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes savings for distributed
KernelShapand avoids saving internal explainer.