Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead code #31

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Remove dead code #31

wants to merge 1 commit into from

Conversation

gy741
Copy link

@gy741 gy741 commented Oct 25, 2019

Hello,

The "cd" variable does not appear to be used.

Thanks.

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@herflis herflis changed the base branch from master to develop November 7, 2019 17:09
@tusmester
Copy link
Member

Thank you for spotting this. Instead of removing the variable we should add an assert for it so that we test the datetime dynamic type/property as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gy741 @CLAassistant @tusmester